Skip to content

Conversation

@peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Nov 7, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/64184


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@peterwilsoncc peterwilsoncc force-pushed the fix/64184-update-cdn-for-17-0-2 branch from aed4efa to 4978b4b Compare November 7, 2025 21:54
@peterwilsoncc peterwilsoncc force-pushed the fix/64184-update-cdn-for-17-0-2 branch from 57679c9 to 9f04266 Compare November 7, 2025 21:58
@peterwilsoncc peterwilsoncc force-pushed the fix/64184-update-cdn-for-17-0-2 branch from e2ca6e3 to 9f4ee73 Compare November 7, 2025 22:02
@peterwilsoncc peterwilsoncc marked this pull request as ready for review November 7, 2025 22:18
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, paulkevan, wildworks, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterwilsoncc - I can see the switch to spaces in src/js/_enqueues/vendor/twemoji.js

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected. The emojis are being loaded from the new CDN endpoint.

image

Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterwilsoncc! This is working great. I left a small suggestion to alter the related test assertions, but don't feel strongly about that.

One other thought I had that I wanted to document: what if we maintain the tag search, but use the gh-pages one as a fallback when the tag is not available?

I don't think this is necessary, especially since the maintainer of the library has said that removing the reliance on the tag/release itself in GitHub is preferred.

@peterwilsoncc
Copy link
Contributor Author

One other thought I had that I wanted to document: what if we maintain the tag search, but use the gh-pages one as a fallback when the tag is not available?

I don't think this is necessary, especially since the maintainer of the library has said that removing the reliance on the tag/release itself in GitHub is preferred.

I'm inclined not to given we've been told the deploys (which cover both npm and gh-pages) are more reliable that the tags.

@peterwilsoncc
Copy link
Contributor Author

Merged in r61194 / 875e8e8

@peterwilsoncc peterwilsoncc deleted the fix/64184-update-cdn-for-17-0-2 branch November 10, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants