-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update Twemoji CDN endpoint for Twemoji 17.0.2 files. #10492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Twemoji CDN endpoint for Twemoji 17.0.2 files. #10492
Conversation
aed4efa to
4978b4b
Compare
57679c9 to
9f04266
Compare
…hat changed." This reverts commit a66d728.
e2ca6e3 to
9f4ee73
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-Authored-By: paulkevan <[email protected]>
pkevan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterwilsoncc - I can see the switch to spaces in src/js/_enqueues/vendor/twemoji.js
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desrosj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterwilsoncc! This is working great. I left a small suggestion to alter the related test assertions, but don't feel strongly about that.
One other thought I had that I wanted to document: what if we maintain the tag search, but use the gh-pages one as a fallback when the tag is not available?
I don't think this is necessary, especially since the maintainer of the library has said that removing the reliance on the tag/release itself in GitHub is preferred.
I'm inclined not to given we've been told the deploys (which cover both npm and gh-pages) are more reliable that the tags. |

Trac ticket: https://core.trac.wordpress.org/ticket/64184
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.